xMashedxTomatox / pe

0 stars 0 forks source link

Error messages for date related fields is inaccurate #10

Open xMashedxTomatox opened 2 years ago

xMashedxTomatox commented 2 years ago

Keying in invalid dates gives a inaccurate error message, Dateline can only take dd/mm/yyyy ... and must have a description. With that error message it is intuitive to expect that commands such as deadline 3 d/Lunch meeting 31/06/2022 would be accepted, however because 31/06/2022 is an invalid date, the command is rejected without a mention that an invalid date was keyed in.

image.png

nus-pe-script commented 2 years ago

Team's Response

  1. dd/mm/yyyy requires that the date input be valid.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The justification of this rejection does not make sense to me as dd/mm/yyyy does not imply that the date input must be valid. It is a stretch to even assume that integers > 31 cannot be a valid day, same for month and year etc as the error message did not mention that dd/mm/yyyy signifies a date. However, intuitively, we can make sense that dd/mm/yyyy represents values corresponding to date values. Even then, 31/06/2022 seems to perfectly conform to the dd/mm/yyyy format despite it not being a valid date. Therefore, the error message lacks significant information as rather than being an incorrect format(as shown by the error message), it should say explicitly say that the date given is not real.