xMashedxTomatox / pe

0 stars 0 forks source link

Multiple sequence diagrams that have very areas that are very similar #14

Open xMashedxTomatox opened 2 years ago

xMashedxTomatox commented 2 years ago

As seen from the seq diagrams below, the parser sections are repeated. As these are both seemingly complicated diagrams, it would make more sense to separate out the command parsing section as it makes it very hard to understand the sequence diagram when there is too much information in it.

image.png

image.png

nus-se-bot commented 2 years ago

Team's Response

  1. The diagrams are correct, and these 2 diagrams come from 2 separate components, meaning that the given user inputs are both distinct.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The reason i am arguing for this point is that multiple of these sequence diagrams that contain the section on parser. And the top part of these diagrams can all be represented by a general command, e.g. XYZCommandParser. This would make the diagrams a lot easier to read, as the top part is simply just a repeat. The argument that the user inputs needs to be distinct doesn't make sense at least for the top section as it can just be represented as execute(xyz ...)`


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]