search

xMashedxTomatox / pe

0 stars 0 forks source link

Validation of email is incorrect #5

Open xMashedxTomatox opened 2 years ago

xMashedxTomatox commented 2 years ago

Currently, it is possible to add users with email in the form of x@y without specifying a top level domain. These are not valid email addresses and should be handled appropriately.

image.png

soc-se-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Email not checking domain properly

Considering that the application is designed for interior designers to manage their contacts.

The contacts should have external email addresses.

However, the below command

add n/charlie p/81234567 e/gmail@gmaill

was able to create a record in the app.

See screenshot

image.png

Considering that the contacts are external, there should have been a domain check on the email.

i.e. [DomainName].[TDL]

[original: nus-cs2103-AY2122S2/pe-interim#2046] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot https://en.wikipedia.org/wiki/Email_address#Examples

image.png

image.png

  1. TLD is not a compulsory field for email addresses.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]