xMasterX / all-the-plugins

Big plugins pack built for latest flipper firmware (builds in releases for UL only)
GNU General Public License v3.0
1.05k stars 96 forks source link

Fix apps using the View Dispatcher without running it #159

Closed CookiePLMonster closed 2 months ago

CookiePLMonster commented 3 months ago

This PR fixes apps that had input processing broken after https://github.com/flipperdevices/flipperzero-firmware/pull/3703. When the upgraded View Dispatcher was used without running it with view_dispatcher_run, the event queue on the UI thread eventually clogged, and it wasn't letting the app message pumps process inputs to begin with. For these cases, I migrated the apps to use a View Holder as the firmware PR recommends.

The following apps have been upgraded:

The following apps have not been upgraded:

Both apps now also respect the loader stop thread signal.

xMasterX commented 3 months ago

Thanks! And about outdated versions of some apps, I'm aware of the updates, but can't work on them rn, I posted details in our communities in telegram and discord about my health situation, Ill work on them as soon as it gets better, hopefully in next weeks or sooner