search

xMoad / marave

Automatically exported from code.google.com/p/marave
GNU General Public License v2.0
0 stars 0 forks source link

No click sound on windows xp (@rev274, PyQt 4.7) #54

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
I'm running Marave @rev 274 on Windows XP, PyQt 4.7.
When I set click sound type I can hear the sound, but typing in the editor
makes no sound.

I tried to debug it, looking at the self.beep.play() call in eventFilter
and in setclick. The self.beep object looks the same but it doesn't play
correctly when typing.

Original issue reported on code.google.com by pierpaol...@gmail.com on 15 Feb 2010 at 9:17

GoogleCodeExporter commented 8 years ago 
I ĺl take a look at it soon.

Original comment by roberto.alsina on 16 Feb 2010 at 12:01

GoogleCodeExporter commented 8 years ago 
It seems that the behavior of MediaObject is such that when playback is 
finished the
position in the stream is kept. To start another playback you need to seek to 
the
beginning.

I attached a modified version of main.py (just added one line in eventFilter).
This one works fine on Windows.

Original comment by pierpaol...@gmail.com on 18 Feb 2010 at 10:23

Attachments:

GoogleCodeExporter commented 8 years ago 
I improved a bit the code connecting the finished event with a function to seek 
to
the beginning.

I also removed some print I had used for debugging. Should be clean now.

Original comment by pierpaol...@gmail.com on 18 Feb 2010 at 10:37

Attachments:

GoogleCodeExporter commented 8 years ago 
This is yet another version.
When you type quickly keys are pressed before the sound ends playing.
In this implementation the sound is stopped and another one is started as soon 
as you
press a key.
The effect sounds pretty good.

We should decide what kind of behavior we want as clicks and keys cannot be 
synchronized.

Original comment by pierpaol...@gmail.com on 18 Feb 2010 at 10:49

Attachments:

GoogleCodeExporter commented 8 years ago 
I think I like better the one from comment #4

Original comment by roberto.alsina on 18 Feb 2010 at 10:57

GoogleCodeExporter commented 8 years ago 
Committed in r344 and verified to work well on Linux, if it's ok on Windows, 
you can close 
the issue.

Original comment by roberto.alsina on 18 Feb 2010 at 11:01

GoogleCodeExporter commented 8 years ago

Original comment by pierpaol...@gmail.com on 19 Feb 2010 at 7:19