xNS5 / rentalreviewsdata

GNU General Public License v3.0
1 stars 0 forks source link

[Google Scraper] Config.json updates #16

Closed xNS5 closed 2 months ago

xNS5 commented 3 months ago

Migrate the rest of the CSS/XPATH selectors to the config.json file

Ideally something like

{
"global": {...},
"reviews": {...}
}

Where global values are ones shared between both scrapes, such as review element CSS classes, review author class, etc.

xNS5 commented 3 months ago

Add another key, "disclaimers" comprised of slug key : string value pairs. The intent for this is to add some kind of disclaimer message to the JSON objects in situations such as when a company changes their name or is acquired by another company. For example, Son-Rise Property Management doesn't technically exist anymore -- while they were acquired by PURE property management that doesn't mean they kept the old staff and practices. On the other hand, it could also have been simply a rebrand under PURE. I don't believe that it's honest to combine Son-Rise with PURE, but there needs to be some kind of association between the two and I believe that some kind of disclaimer is a fair compromise.

xNS5 commented 2 months ago

Included this in #26 with the OpenAI updates. The disclaimers is necessary for both Yelp + Google, so doing it specifically for Google doesn't really make sense in hindsight. Closed.