search

xNul / drop

A LÖVE visualizer and music player
MIT License
20 stars 2 forks source link

Timestamp does not update for the final queued samples of the song #22

Closed xNul closed 6 years ago

xNul commented 6 years ago

Since there isn't a way to know when audio samples are processed, timestamps are currently calculated when audio samples are queued. When the end of the song is reached by the queuing system, there aren't anymore audio samples to queue, so it stops queuing which means the timestamps stop updating.

There are a couple solutions to this, but they aren't very solid. They would break easily and it would be a pain to implement. Additionally, this bug is so small it's impossible to notice, but if a dynamic queue size is implemented or the queue size is increased in the future, it could become noticeable.

xNul commented 6 years ago

Figured out a full-proof method to fix this.