search

xNul / drop

A LÖVE visualizer and music player
MIT License
20 stars 2 forks source link

Interacting with the window border (minimizing/resizing/moving window/etc) or sometimes switching to fullscreen, pauses playback #4

Open xNul opened 7 years ago

xNul commented 7 years ago

Because of commit https://github.com/xNul/drop/commit/93eec1a518581f7ae7c63f26dc09aa4c6a54455d, there is now a bug where music temporarily stops due to the above reasons. In order to fix, audio would have to be moved to a separate thread, but even then it doesn't account for the visual stall.

xNul commented 6 years ago

Identified issue and submitted a bug report to the official LOVE repo here

zorggn commented 5 years ago

Since the above linked issue was closed as "not viable to implement" basically, i could suggest that, at least for continuous sound playback, another löve thread could be used to do the QSource data queueing on, as you already mentioned; can't do too much about the visuals at this point sadly.

(As an aside, i did a test project myself sometime in the past with threading, and i managed to put everything on the lua side, except love.event.pump and graphics and window calls in love.run into a separate thread, but i must admit, i haven't experimented further with it; maybe it'd be possible to somehow transfer/access those from the separate thread as well...)

xNul commented 5 years ago

I'm planning to put audio playback in a separate thread, but getting everything working from a separate thread (or only graphics + audio) would be a complete solution. I'll do some experimenting when I come back to this project and hopefully figure out a workaround, although, I doubt it :(