xNul / palworld-host-save-fix

Fixes the bug which forces a player to create a new character when they already have a save. Useful for migrating maps from co-op to dedicated servers and from one dedicated server to another.
MIT License
887 stars 68 forks source link

The fix process is stalled #101

Closed zw4415 closed 5 months ago

zw4415 commented 5 months ago

During the fix process, I have been in the stage of completing the changes and cannot proceed to the next step. The program hasn't been closed, it just stays still Is it related to the Python version?

Evolution0 commented 5 months ago

It always seems to hang at the end but it does eventually finish though with the way the script is currently written it does not give a clear indication of progress or status (just the current stage), likely though this is due to using an outside binary (uesave.exe) and having to wait on it to complete its operations.

I haven't really dug into the code to check if the current progress messages are something in the script or passed through from uesave but if uesave has any meaningful sdout and its not currently visible to the user it may be worth passing that through. If it doesn't though then not much that can be done about it.

xNul commented 5 months ago

On my pretty beefy computer it still takes about 30 seconds so on a normal computer, it can take awhile. It takes so long because it basically has to convert 1+ GB of JSON data back into .sav format. Just leave it for an hour and I'd be very surprised if it's not done by then on any relatively modern computer.