Fix/new save path

[riffy]

Instead of checking if the new save file NOT existing (which gets deleted anyway later), it is now check if the file already exists and warns the user about the occurence.

From my understanding the new_save_path was only used to delete and then rename the old save file, after changes have been done, so the file itself wasn't necessary in the first place.

[Lynxaa]

Both the new guid save file and old guid save file need to be present in the Players folder, at least from my understanding, hence the message.

[riffy]

Why? The only thing that happens to the (existing) new save file: it gets deleted.

So why is the FILE needed?

[Lynxaa]

Why? The only thing that happens to the (existing) new save file: it gets deleted.

So why is the FILE needed?

In practice the file is not needed, you're correct, only the new GUID.

My guess for it being a requirement is to ensure the user has followed the instructions correctly, or perhaps, if in future, data may need to be copied from the new save too.

I personally don't see any issue with doing it the way that it's currently designed, but it's not up to me :)

[Derek-G1]

I would like to bring to your attention a potential oversight in the provided instructions related to the process of copying player IDs. It appears that there may be a missing step, specifically concerning the necessity to copy both the old and new player IDs to the designated temporary players' folder.

I became aware of this discrepancy when encountering errors in the script, which indicated a requirement for the old player ID. However, the instructions did not explicitly state the need to copy both IDs to the temporary folder. I wish to seek clarification on whether there is an implicit understanding or if there may be a step missing from the documentation.

Your prompt feedback on this matter would be greatly appreciated.

Thank you for your attention to this concern.

Kind regards,

[xNul]

@Derek-G1 apologies if the README was unclear, you're supposed to copy the whole save folder over to the temporary folder, not just individual player .sav files. Thanks for your input, I'll look over the instructions again and see if that can be made more clear.

[xNul]

@Lynxaa is correct. The check for the existence of new_save_path is to ensure the user has created a character before running the script. If someone were to figure out the new GUID another way, without creating a new character, the fix wouldn't work. Appreciate trying to help, but I'm going to have to close this PR.