search

xRuiAlves / fide-ratings-scraper

FIDE (International Chess Federation) ratings pages scraper built with NodeJS
MIT License
49 stars 22 forks source link

Did you really not include any endpoint for search queries? #3

Closed aloysiuslip closed 4 years ago

aloysiuslip commented 4 years ago

Surely the first thing anyone wants to do with this database is look up a name. If you're require a FIDE ID first then the utility of this is extremely limited.

xRuiAlves commented 4 years ago

Thank you for your input. A person's name is not unique, and therefore does not identify in an unique way a given entity (e.g. by searching John Smith, there will be many different people with that same name, ergo it is not possible to fulfill the request). Anyhow, I'm not sure that the fact people have to query info by their FIDE ID is limiting the use of the API in any way, since people do know their FIDE ID (and this ID does not change through time)

aloysiuslip commented 4 years ago

So there should be some endpoint which is a 'search' endpoint - you enter a search string, such as John Smith and it returns a list of search results, complete with IDs and extra metadata that users within an app could then use to fetch their ID.

DanijelDomazet commented 11 months ago

Surely the first thing anyone wants to do with this database is look up a name. If you're require a FIDE ID first then the utility of this is extremely limited.

Well, it depends... my use case (chess club members web page) is pretty much covered by this implementation. 👍