xRyul / obsidian-image-converter

⚡️ Convert and compress images from one format to another by drag'n'dropping or pasting files into the note. HEIC, TIF, JPG, WEBP, PNG.
MIT License
168 stars 16 forks source link

If one note is open in two devices that are in sync ... #85

Closed Dopairym closed 1 day ago

Dopairym commented 4 days ago

If one note is open in two devices that are in sync ( I'm using syncthing ) and then if i insert an image in one of the devices while the note is also open in the other devise the first devise will rename it and also the second devise will try to sync it and this brake the file ( in my case i insert and gif the first device renames it and it stays with .gif but when the image gets synced into the second device it changes gif to png )

garugc commented 4 days ago

since the last update i also have chaos everywhere. Several graphics have disappeared completely at random. Then I restored them from the trash can. But as soon as I open obsidian on my phone and it synchronizes (with Remotely safe), Image Converter processes several graphics again (even though they were already processed on the PC) and chaos ensues again. The graphics in the Notes are deleted again. I have entered the same path for new graphics in Image Converter on the PC and the cell phone. But this is not about new graphics but about graphics that have already been saved. I have now spent an hour checking all the Notes because I am afraid of losing data. Edit: I had set everything up again and after a new sync a lot of pictures were automatically moved to the trash again. Completely random. I have now deactivated the plugin.

xRyul commented 4 days ago

I don't use Syncthing nor Remotely Save, so there is no official support for any of them. If you can help me understand how they work and what they do, I will try look into it.

garugc commented 4 days ago

There were never any problems before, only now after the update. I suspect that Image Converter identifies the synchronized images as newly imported files at the very moment when the synchronization process is still in progress. This creates a conflict because Image Converter or Obsidian renames the file and the link to the image in the note is changed as a result. I am not a programmer and do not know how the processes at Remotely Safe work. But since I don't want to do without it, I unfortunately have to deactivate Image Converter.

garugc commented 4 days ago

Ok, I see, there is the option "If an output file already exists".. and that's why I always had the images with an additional “-1” in the folder and the links in the Notes were no longer correct. Probably because Remotely safe synchronized the changed file directly. I don´t know..

Dopairym commented 4 days ago

This will be also great feature to add i mean like a togglable function ao it renames all the attachments https://github.com/xRyul/obsidian-image-converter/issues/84

On Fri, 8 Nov 2024, 7:34 pm garugc, @.***> wrote:

Ok, I see, there is the option "If an output file already exists".. and that's why I always had the images with an additional “-1” in the folder and the links in the Notes were no longer correct. Probably because Remotely safe synchronized the changed file directly. I don´t know..

— Reply to this email directly, view it on GitHub https://github.com/xRyul/obsidian-image-converter/issues/85#issuecomment-2465123788, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBBOOAMCWEU2XPOZAXBJTDDZ7TOJZAVCNFSM6AAAAABRNEA7USVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRVGEZDGNZYHA . You are receiving this because you authored the thread.Message ID: @.***>

xRyul commented 4 days ago

There were never any problems before, only now after the update. I suspect that Image Converter identifies the synchronized images as newly imported files at the very moment when the synchronization process is still in progress. This creates a conflict because Image Converter or Obsidian renames the file and the link to the image in the note is changed as a result. I am not a programmer and do not know how the processes at Remotely Safe work. But since I don't want to do without it, I unfortunately have to deactivate Image Converter.

I am trying to look into it.

Could you test following and see if issue still persists: image-converter-1.2.3.zip

garugc commented 4 days ago

I´ll test it later. What I found out now: I insert a picture named "xxx" and there is no other picture with the same name. Image Converter automatically renames it to “xxx-1”. Then it is synchronized and on my phone Image Converter renames the new image to “xxx-1-1” again. Then it synchronizes and on the PC the file is suddenly called “xxx-1-1-1”

garugc commented 4 days ago

Your update seems to work. The files are not renamed and in my test syncing works normal. Thank you very much!

xRyul commented 3 days ago

@Dopairym and @garugc please update to the latest release and see if it fixes this issue 🤞

garugc commented 3 days ago

Yes, it works. Thank you very much!!