search

xSuperr / VanillaBlocks

A plugin to add more blocks to PocketMine
GNU General Public License v3.0
26 stars 12 forks source link

Add Trapdoor, all strairs ans polished basalt #16

Closed Dhaiven closed 3 years ago

Dhaiven commented 3 years ago

Ok

Dhaiven commented 3 years ago

Now is good ?

xSuperr commented 3 years ago

Yeah, can you test if everything is working? Once poggit comes back online I will merge.

Dhaiven commented 3 years ago

I have already tested everything and everything works perfectly

xSuperr commented 3 years ago

Ok fix the conflicting files, and apparently poggit-ci detects a syntax error in the file, if you could look into that and fix the issue then I can merge.

Dhaiven commented 3 years ago

Now is good ?

xSuperr commented 3 years ago

VanillaBlocks.php still needs to have the register functions for the two log blocks (Check main file of my plugin), and you removed the register function for your trapdoor blocks.

Dhaiven commented 3 years ago

Oups

Dhaiven commented 3 years ago

Normally, the "main" brache is good

xSuperr commented 3 years ago

Then please open a new pull request on the main branch of your fork.

Dhaiven commented 3 years ago

The Test branch work to