xTVaser / pcsx2-rr

PCSX2-rr - The Playstation 2 Emulator with TAS Tools (Now Merged into PCSX2 Core!)
http://pcsx2.net/
Other
33 stars 6 forks source link

CRC hacks and gamefixes for Jak 2/3 prototype builds #68

Closed LuminarLight closed 3 years ago

LuminarLight commented 3 years ago

For these game builds, we have to run DISKINFO.BIN/FIREWIRE.IRX directly, due to the pnach limitations. But this makes it necessary to add new fixes into the emulator. These changes are not needed in official build - there you just run the iso normally. But in this pcsx2 build, these are needed.

After these changes, graphics will look nice due to the CRC hacks. And models won't be stretched out anymore, since the emulator will automatically enable VU0 kickstart.

xTVaser commented 3 years ago

Hmm, this seems more appropriate to open over on upstream/pcsx2 and then i can just merge the changes here. Seems like demos and such are already added to these files so i don't imagine they would have objections.

LuminarLight commented 3 years ago

If you think they will accept this.... I will open a PR for them later today.

LuminarLight commented 3 years ago

Closing this for now. If official PCSX2 doesn't accept it, I may have to reopen it.

LuminarLight commented 3 years ago

Official PCSX2 did not accept it.

xTVaser commented 3 years ago

Ah i see the problem now for why they weren't happy about it. Unfortunate that it opens up this build to the same potential clashing issues, the potential impact is much smaller atleast.