search

xTibor / egui_extras_xt

MIT License
82 stars 9 forks source link

Use Iterator instead of InclusiveRange #16

Closed Ablu closed 1 year ago

Ablu commented 1 year ago

This allows us to drop the #![feature()] attribute, which allows us to use this from stable rust.

The implementation did not actually require getting start() or end(). So an iterator seems to suffice here?

Chances are that I am missing something here and there are bigger plans... I just wish I could use this from stable :)

xTibor commented 1 year ago

I went a different path in 22942fbfeec3b2347326e0685bd30806bb7e5fa2, you can now use this lib from stable Rust.

Ablu commented 1 year ago

Ah. That's a lot better of course... Did not realize that there was an iterator-based version already. Thanks! Do you plan to publish this on crates.io? :thinking: :innocent:

xTibor commented 1 year ago

Wish I could publish it on crates.io however it would be a bit premature at this state. Lots of things are still experimental, unfinished or unpolished in the crate. And the general lack of documentation is an another problem.

Ablu commented 1 year ago

No worries. I have no problems pointing to a git. Don't let perfect become the enemy of good though! I think there is a lot of nice stuff in here!