FilterDemo extensions

[GoogleCodeExporter]

FilterDemo project was extended:
* Added Bilateral filter option (see issue #283)
* Saving image processed
* Copying it to Clipboard

Original issue reported on code.google.com by smaxm...@gmail.com on 29 Jan 2012 at 10:56

Attachments:

• FiltersDemo.zip

[GoogleCodeExporter]

The point of this fix is not clear. To me it does not make much sense. The 
point is that the FilterDemo never ever is supposed to become full functional 
application which is ready to be used by an end user. It is just a sample for 
developers to demonstrate how to call some image processing routines.

There is an application like IPLab, which already contains saving and copying 
to clipboard. So I would say extension to support Bilateral filter is valid 
there, but not of big use in the "Hello World" sample.

Original comment by andrew.k...@gmail.com on 8 Feb 2012 at 9:58

• Changed state: Pending

[GoogleCodeExporter]

Originally I've amended the project to add Bilateral filter support. But latter 
while I was playing with the demo I've found that I was missing easy save/copy 
functionality while checking results in Photoshop.

That's why I've added this minor changes.

You may consider this as an end-user feedback and I've voted for expanding the 
functionality :)

Original comment by smaxm...@gmail.com on 9 Feb 2012 at 11:53

[GoogleCodeExporter]

>> But latter while I was playing with the demo I've found that I was
>> missing easy save/copy functionality 
Well, as I mentioned before, that application is just a small sample, which is 
not supposed to provide much functionality.

Anyway, the code has issues, which are not acceptable for a useful 
functionality:
1) Why PNG images are supported on saving, but JPG and BMP are not?
2) Why there is not exception handling when saving images? Or where is the 
guarantee that nothing ever happens?
3) The copy image menu item is never gets disabled. So you can click it right 
away after starting the application. And since you don't check for null, the 
application nicely crashes.
4) Usually UI forms have OK/Cancel buttons, but not Start. If you have Start 
button, then it makes impression that something will run in background thread 
providing progress and there will be Stop button maybe. Anyway, after you show 
the form, you never check for DialogResult - what if user canceled the form and 
does not want any filter to be done?

Original comment by andrew.k...@gmail.com on 13 Feb 2012 at 8:30

• Changed state: Rejected