xXBJXx / ioBroker.elgato-key-light

With the Elgato Key Light Adapter you can query and control Elgato lamps like Elgato Key Light / Elgato Key Light Air.
MIT License
1 stars 2 forks source link

[Feature]: Rename Datapoints #2

Closed KoMa1978 closed 1 year ago

KoMa1978 commented 1 year ago

Is your feature request related to a problem? Please describe.

Please rename the datapoints from "datapoint" to "<<keylight / Info / Displayname>> - datapoint" example Now: "Brightness" Wanted: "Keylight Links - Brightness"

It is hard to understand a script if there are multiple keylights I want to control.

image

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

xXBJXx commented 1 year ago

is it enough if i do this only for the light.lights? or should this be done for all states image

KoMa1978 commented 1 year ago

Hmm,

I would prefer to have all data points named similar. If I look at my other objects, like HomeMatic, all the datapoints start with the "DeviceName" then a "." and the the datapoint: image I think this is the most flexible way.

xXBJXx commented 1 year ago

Please install from GitHub and try if it fits like this

KoMa1978 commented 1 year ago

Looks very good! Thanks a lot!

There are some datapoints (maybe old ones) without the name and the folders have no name included ... OK not really needed but will look better ;-)

Just a personal opinion: I think a "." or "_" as separator between the devicename and datapoint would be better.

image

Again thanks a lot!! You should add this adapter to the default iobroker repository.

xXBJXx commented 1 year ago

The folder names I can also still adapt, and "." or "_" I can also still make. The adapter will also be added to the ioBroker repo, but it has to run and be tested for a few weeks.

I will make the request in a few days after that, it will take a few weeks until the adapter is tested, and possible bugs are fixed.

xXBJXx commented 1 year ago

The state name does not exist any more, you can delete it

KoMa1978 commented 1 year ago

Great work!! Again!! Works much better than my Javasrcipts ;-) I used a couple of days to turn on/of my video lights with a HomeMatic Switch and it very reliable.

xXBJXx commented 1 year ago

so the "." and "_" doesn't look so good, because the states also have names from more words e.g. elgato-key-light.0.EW40K1A09882.info.firmwareBuildNumber that looks like Elgato Light Strip Test_Firmware Build Number Elgato Light Strip Test.Firmware Build Number. I could possibly add a "/", that looks a little better => Elgato Light Strip Test / Firmware Build Number.

KoMa1978 commented 1 year ago

Yes you are right, a „/„ looks better.

at least everything different from a whitespace makes it much clearer that it is a separator

xXBJXx commented 1 year ago

Have adjusted it, please check

KoMa1978 commented 1 year ago

Niiiiiiiicccee ;-)

What I've seen is that the datapoint names are first letter uppercase for data points but not for folders.

And regarding the folders, does it make sense to name them "Name / Folder / Datapoint" (example: "Key Light RECHTS / Wifi-Info / SSID"?

image

Yes at the moment there are only unique names but I don't know if the other Elgato devices have subfolders with identical datapoint names, like lights.0 and lights.1:

image

Not needed by me, but maybe simply use the provided folder structure like "Key Light RECHTS / Light / Lights / 0 / Brighness" is more futureproof?

Thanks again for the great adapter!

xXBJXx commented 1 year ago

Not needed by me, but maybe simply use the provided folder structure like "Key Light RECHTS / Light / Lights / 0 / Brighness" is more futureproof?

I won't do that with the path of the state in the name because that only drags out the name, and then you can't leave it under the objects anymore.

I close the topic, if there is something else you can open it again