search

xabbuh / panda-client

basic PHP client for the Panda encoding service
MIT License
14 stars 5 forks source link

REQ: Add support for new source delete request #5

Closed timhanssen closed 10 years ago

timhanssen commented 10 years ago

Hey all,

Could this new function be implemented in the libary?

DELETE /videos/:id/source.json

Delete only source file from storage

Example request

DELETE /videos/2f8760b7e0d4c7dbe609b5872be9bc3b/source.json

It's a great library btw.

Best, Tim

xabbuh commented 10 years ago

@timhanssen Thank you very much for your proposal. I added that to the 1.2 development version. You can test the new method deleteVideoSource() when changing the version constraint in your composer.json file to ~1.2@dev. Please note that the new method was not added to the CloudInterface to keep backward compatibility, but was only added to the Cloud class. Please let me know if it works as expected for you.

timhanssen commented 10 years ago

@xabbuh it works exactly as I hoped it would. Thanks for the quick adding!

xabbuh commented 10 years ago

@timhanssen Thank you for reporting this. Did you spot any other feature of the API that is not covered by the client?

timhanssen commented 10 years ago

@xabbuh i will ask my colleague for that, the only thing that I think could be a nice addition is a way to process the notidfications send back by Panda.

xabbuh commented 10 years ago

@timhanssen Thanks, otherwise I'll tag a new stable release until the end of the week.

I don't think that it really makes sense to implement the handling of notifications in this client library (because in the course of notifications, the "client would have to act as a "server"). If you use the Symfony framework, you can use the PandaBundle which integrates this library and also offers support for dealing with notifications.

timhanssen commented 10 years ago

@xabbuh thanks, i will take a look at that! We're using Laravel framework atm.

xabbuh commented 9 years ago

@timhanssen FYI, I released the stable 1.2.0 version just now.