xability / maidr

Multimodal Access and Interactive Data Representation
GNU General Public License v3.0
21 stars 7 forks source link

fix(scatterplot): address an issue where points remain highlighted even after maidr is deactivated #527

Closed krishnanand5 closed 1 month ago

krishnanand5 commented 1 month ago

Bug Report

Description

On a scatterplot, when we navigate through it, points are highlighted based on the direction we navigate the plot. When maidr is deactivated on the plot, the last highlighted plot points remain highlighted and the plot does not return to its original state. This is residual from the invocation of maidr on the plot and should be removed when maidr is deactivated.

A follow-up scenario for the same is based on autoplay. If autoplay was in action when maidr was deactivated, the last highlighted plot points remain highlighted but when maidr is re-activated on the plot, autoplay immediately resumes from the left extreme of the plot autonomously.

Steps to Reproduce

  1. Open a scatterplot example
  2. Navigate through the plot and deactivate maidr with some plot points highlighted on the screen.
  3. The highlighted plots points remain highlighted whereas maidr has been deactivated, thus resulting in residual elements on the user interface.
  4. For the autoplay scenario, activate autoplay and deactivate maidr when autoplay is in action.
  5. If maidr is activated again, autoplay immediately starts from the extreme left without the user having started autoplay.

Actual Behavior

Highlighted points remain highlighted and autoplay is functioning autonomously if maidr is deactivated when autoplay is running.

Expected Behavior

When maidr is deactivated, the highlighting components (in the case of scatterplots, circle) should be removed and if autoplay was running, it should be killed before maidr components are destroyed.

Screenshots

In this screenshot of a scatterplot example, certain points on the plot are highlighted eventhough maidr is inactive.

scatter_active

Environment

jooyoungseo commented 1 month ago

Closed via #528