[iOS Bug] IndexOutOfRange when setting the Text property

[Phenek]

My implementation is like so:

            var tab = new AccountPage();
            var navigation = new NavigationPage(tab)
            {
                Title = "Profil",
                Icon = "Profile",
            };

            tab.SetBinding(TabBadge.BadgeTextProperty, nameof(BottomMenuViewModel.Count));
            tab.SetBinding(TabBadge.BadgeColorProperty, nameof(BottomMenuViewModel.Color));
            tab.SetBinding(TabBadge.BadgeTextColorProperty, nameof(BottomMenuViewModel.TextColor));
            tab.BindingContext = viewModel;
            Children.Add(navigation);

When changing the BadgeTextProperty I got an IndexOutOfRange on iOS Only. Message: Index was outside the bounds of the array.

The StackTrace take me to the Plugin.Badge.iOS.BadgedTabbedPageRenderer.OnTabbedPagePropertyChanged

[Phenek]

I think is about the CheckValidTabIndex function in the iOS Renderer

The function is searching for the IndexOf(tab) and need to be the IndexOf(navigation) regarding my implementation. #58

[Phenek]

For a workaround we could do :

        public bool CheckValidTabIndex(Page page, out int tabIndex)
        {
            tabIndex = Tabbed.Children.IndexOf(page);
            if(tabIndex == -1 && page.Parent != null)
            {
                 tabIndex = Tabbed.Children.IndexOf(page.Parent);
            }
            return tabIndex < TabBar.Items.Length && tabIndex >= 0;;
        }

Regards,

[xabre]

PR #63 was merged and released with v2.1.1