search

xabriel / listen-to-wikipedia

Live, generative music from Wikipedia edits
http://listen.hatnote.com
Other
1 stars 1 forks source link

Add sound. #7

Closed xabriel closed 1 year ago

xabriel commented 1 year ago

This PR adds sound back.

This is likely messy, so opening for feedback as a Vue newbie.

Still need to rebased with latest changes from the vue-rewrite branch.

xabriel commented 1 year ago

All right @tchin25 this is working, but looking for feedback on whether it is Vue-ish code? Should I move code to its own .js? How? Etc.

tchin25 commented 1 year ago

A lot of it can probably be moved into its own js file. I know calculate_size() would also be useful in Visualizer.vue. Also I think organizationally the sound loading and triggering might make more sense in the top App.vue component or maybe even Visualizer.vue? It could go either way.

xabriel commented 1 year ago

Ok round two. Please re-review.

tchin25 commented 1 year ago

Looks good!