xach / zs3

Work with Amazon S3 and Amazon CloudFront from Common Lisp
http://www.xach.com/lisp/zs3/
Other
38 stars 16 forks source link

50x responses, and other fixes #20

Closed nicklevine closed 7 years ago

nicklevine commented 8 years ago

Handle 50x responses. Pass amz security headers to head requests. Readers for interrogating response objects

xach commented 8 years ago

Indentation in https://github.com/xach/zs3/pull/20/commits/64949b160d9d99d63c28322736aafee067a766c5 looks off - tab damage, or just needs reindenting?

nicklevine commented 8 years ago

Source of confusion located. Following commit (1324a84) on interface.lisp removes two spaces from that line, taking indentation from 4 spaces down to 2. Apologies for the confusion.

quicklisp commented 7 years ago

Can you please fix the indentation?

Just looked at the doc changes. A couple things:

nicklevine commented 7 years ago

As already noted (in my previous comment), the indentation was fixed by a subsequent commit which formed part of my original pull request -- it is still fixed and there's nothing else to do!

I have bolded user input in the code example, moved the example about responses to the head of the "Responses" section (and improved the wording), and both noted the condition name and exported the symbol concerned.