xackery / peq-expansions

Project EQ expansions support
4 stars 1 forks source link

Create npcs.sql #27

Closed 5murph closed 5 years ago

5murph commented 5 years ago

This .sql document contains the necessary changes to make progression-based spawn changes, including:

-Adding an expansion column to spawnentry -Blocking out npcIDs by era, and then listing individual NPCs and their respective expansions -Query to use the expansion column to disable spawns in spawn2

edit the spawn disabling query is written to keep the PoR revamps like new Freeport in game, which is why it maxes at xpac 10 for disabling spawns (should people want those zones available for progression instead of the classic versions).

xackery commented 5 years ago

This realm is (hopefully) going to be handled by the PEQ team, as they hold the keys to the database everyone baselines on. Meaning, once we get the foundation injected into eqemu, and the peq-php editor updated (TGP is working on this), this modification would be more focused on them.

So, we may want to move this file to https://github.com/xackery/peq-expansions/tree/master/peq/npcs

the peq subfolder is things that are PEQ related, and will be ingested by them in due time, in one capacity or another.

So, with your OK, i'll merge this in and move where it's at @rudeboy88

xackery commented 5 years ago

There's also some discussion regarding what tables will have the expansions table. You can see my proof of concept/proposal here: https://github.com/EQEmu/Server/blob/peq-expansions/utils/sql/git/required/2019_01_22_peq_expansions.sql

As you see, spawnentry may not contain the expansions field.

spawn2 may instead. I say may, because I'm not sure if spawnentry AND spawn2 will end up with them, just spawnentry, or just spawn2.. it is going to be based on some discussion. If you search for this in discord's #peq-expansion channel you'll see some back and forth related to it, but not suggesting you change this just yet, more something to keep in mind.

xackery commented 5 years ago

Also note there's a min_expansion and max_expansion. Some NPCs get disabled later, others introduced later.

ANOTHER thing to consider is akka suggested/pushed the idea that instead of the 0-99 mentality, where 0 = classic, 99 = an expansion never likely to release, we use:

0 - wildcard *all 1 - classic 2 - kunark etc

so if you want to encompass all expansions, you use the min_expansion 0, max_expansion 0. Again, though, I wouldn't fret over this modification, I just wanted to share and keep this in the back of your mind.

For now, everything in the peq-expansions repo we're contributing to is using 0 - classic, 1 - kunark, and 99 - max value.

5murph commented 5 years ago

Hey @xackery - Sounds good! As far as moving the expansion columns to spawn2 and expansion numbering formats are concerned these would be easy fixes for me to make happen in the future if needed.

With regards to peq and NPCs I'd say the more the merrier :). I agree with the use of a min/max xpac and will use that from now on or until further changes. Thanks!

And of course, if there's any other areas that need looking into with this project (spells, zone objects, etc.) lmk and I'll see what I can dig up.