Notes for megamerge - Githubissues

xackery commented 7 years ago

LIST OF STUFF TO PATCH

[ ] set Rule BuffLevelRestrictions to true (should be)
[x] Lowered chance of elunium and elunium shards from dropping from monsters.
[ ] DELETE FROM character_memmed_spells WHERE spell_id = 1547 OR spell_id = 1546 or spell_id = 1548;
[ ] DELETE FROM character_spells WHERE spell_id = 1547 OR spell_id = 1546 or spell_id = 1548;
[ ] UPDATE zone SET zone_exp_multiplier = 1.00, hotzone = 0;

LIST OF STUFF TO CHECK

[ ] OOC regen and general regen may stack up, verify
[ ] Do a snapshot of live DB and do a local update, see if we can isolate all changes.
[ ] Loot all on corpses bugged?
[x] Look into lowering experience gain and removing hot zone experience, current game is really fast to level.. keep the same curve, though. This would make rested EXP more useful.
[x] Combat was heavily rewritten, hit rate is very high now. Review and ensure it isn't too empowering, or if it is, we can review how to balance things up.
[x] The procs we added custom seem to be proccing too much or too little, review.
[ ] Duelist needs assessment (likely needs to be readded, look at my patch notes or search for RB_ROG_DUELIST in prior version
[ ] pet valor for paladin in Client_Packet is incomplete/broken add ``` if (IsClient() && ndamage > 0) { uint8 rank = CastToClient()->GetBuildRank(ROGUE, RB_ROG_VITALORGANS); if (rank > 0 && zone->random.Roll((int)(5 rank))) { ndamage += ndamage 0.25f * rank; }

}
```
to GetBaseSkillDamage(EQEmu::skills::SkillBackstab, other);
based on special_attacks.cpp
```

TheGrandPackard commented 7 years ago

In order to start world, I had to update the rule_values table to accept larger values:

ALTER TABLE `rebuildeq`.`rule_values` 
CHANGE COLUMN `rule_value` `rule_value` VARCHAR(64) NOT NULL DEFAULT '' ;

TheGrandPackard commented 7 years ago

Also needed to add the legacy tag in eqemu_config.xml to properly connect to the public loginserver:

<loginserver>
    <legacy>1</legacy>
    <host>login.eqemulator.net</host>
    <port>5998</port>
</loginserver>

xackery / rebuildeq-v1