search

xacrimon / dashmap

Blazing fast concurrent HashMap for Rust.
MIT License
3.09k stars 151 forks source link

chore: bump hashbrown to v0.13 && bump MSRV #250

Closed TennyZhuang closed 1 year ago

TennyZhuang commented 1 year ago

Signed-off-by: TennyZhuang zty0826@gmail.com

xacrimon commented 1 year ago

This PR increases the MSRV beyond what I'd like to do right now in addition to not updating other MSRV-related datapoints such as the readme. Is that a requirement of the hashbrown bump?

TennyZhuang commented 1 year ago

@xacrimon Yes, hashbrown also bumped their MSRV to Rust 1.61, I guess it's acceptable while the stable version has been bumped to 1.66.

TennyZhuang commented 1 year ago

Ref: https://github.com/rust-lang/hashbrown/blob/7d01f51be911c656d3b6aa49624ddcc4644e1629/Cargo.toml#L13

Razican commented 1 year ago

Hello, Rust 1.68 is now stable, and Rust 1.61 has been out since May 2022. Would it be possible to merge this and release it? We're getting duplicate hashbrown dependency versions due to dashmap in Boa :( it would be nice to get a consistent versioning across the crate.

TennyZhuang commented 1 year ago

Hi @xacrimon, can this PR get merged?

cuviper commented 1 year ago

FWIW, hashbrown 0.14 is out now, although that further requires Rust 1.64.

TennyZhuang commented 1 year ago

I'd like to bump it to 0.14 in another PR, but I guess the PR can be merged first.