search

xahlee / xah-fly-keys

the most efficient keybinding for emacs
http://xahlee.info/emacs/misc/xah-fly-keys.html
469 stars 80 forks source link

xah-open-recently-closed: drop ido in favor of built-in completing-read #131

Closed DivineDominion closed 2 years ago

DivineDominion commented 2 years ago
  1. Capitalize the "open:" and add a trailing space (as advised by the manual) -- purely taste, not sure if that's too intrusive ;)
  2. Use completing-read instead of ido-completing-read: this allows the user to pick which completion style to use.
    • When the user prefers ido, proper configuration will be having completing-read-function set to ido-completing-read anyway.
    • This makes the function instantly compatible with selectrum, vertico, etc. as well and not override user's choice
xahlee commented 2 years ago

if i use completing-read, it does not seems to auto call ido version.

xahlee commented 2 years ago

no desire to make them compatible with 3rd parties libs. with ido, xfk is fixed with choice of design. opening it up with arbitrary 3rd parties, the user experience became diverse, many of which will lose the effeciency and design goal of xfk, and then more people will ask compatibility with wild packages out there, or question the design choice of xfk (cuz they liked xyz way but they don't really know stuff.). if user know what they doing, really want to use x lib for completion, they can easily do so.

xahlee commented 2 years ago

i fixed the Open spelling issue. thx. next commit.

xahlee commented 2 years ago

if, the gnu emacs mothership, someday, have a improved ido, or some 3rd party completion bundled with emacs, then, we/I might consider swap out ido.