xahlee / xah-fly-keys

the most efficient keybinding for emacs
http://xahlee.info/emacs/misc/xah-fly-keys.html
484 stars 83 forks source link

space c o xah-show-desktop not work in windows #74

Closed loyalpartner closed 4 years ago

loyalpartner commented 4 years ago

https://github.com/xahlee/xah-fly-keys/blob/master/xah-fly-keys.el#L2633

this is not work, because the windows has no program called explore, it's "explorer.exe", plz change

(w32-shell-execute "explore" (replace-regexp-in-string "/" "\\" $path t t)))

to

(w32-shell-execute "open" (replace-regexp-in-string "/" "\\" $path t t)))

or

(shell-command (concat "explorer.exe " (replace-regexp-in-string "/" "\\" $path t t)))
Tiv0w commented 4 years ago

Did you try it ? If so and if it's working, try to open a pull request with the fix, but this repository is not super active at the moment, so there's no guarantee it will be on MELPA soon.

loyalpartner commented 4 years ago

75 i test in win10

xahlee commented 4 years ago

fixed. thanks @loyalpartner