search

xai4space / meteors

Package for Explanations of Remote Sensing Imaginery
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

minor precommit fixes #24

Closed Fersoil closed 4 days ago

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 33.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

WolodjaZ commented 4 days ago

So based on the change:

--exit-non-zero-on-fix will cause Ruff to exit with a status code of 1 if violations were found, even if all such violations were fixed automatically. Note that the use of --exit-non-zero-on-fix can result in a non-zero exit code even if no violations remain after fixing.

We want to crash every time when there are fixable changes by the ruff yes? @Fersoil

Fersoil commented 4 days ago

For now the precommit fails if files are incorrectly formatted. The workflow is as follows: Formatting checks are done, then ruff does the formatting, but even if the formatting is fixed, it returns non-zero status. I want to pass the precommit only if ruff fails to format the code