search

xai4space / meteors

Package for Explanations of Remote Sensing Imaginery
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

feat: minor precommit fixes - changed ruff parameters #27

Closed WolodjaZ closed 3 days ago

WolodjaZ commented 3 days ago

I rearranged the pre-commits to run those that fix issues first and checks later. However, the problem persists even with the correct flags set. For example, with Ruff, the --fix flag should return 0 if it fixes issues, but it returns 1. I'm not sure why this happens, as the --exit-non-zero-on-fix flag should handle this behavior, but we don't use this flag and still encounter this behaviour.

I also added all necessary flags for each formatter to attempt fixes where possible and specified the Python version for reproducibility. In my opinion, @Fersoil, you can check and try it, but I've already done this. My advice is to leave it as it is (maybe remove the later pre-commits) and, at most, write an issue on the Ruff repository page.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Flag Coverage Δ
unittests 33.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.