search

xaicron / p5-Net-APNs-Extended

Client library for APNs
Other
2 stars 6 forks source link

no error when response is '' #7

Closed mosasiru closed 9 years ago

mosasiru commented 9 years ago

@xaicron

When APNs close a connection, Net::APNs::Extended::Base::_read method returns "", then retrieve_error returns {"command":null,"identifier":null,"status":null} now. So I think we should ignore "" at retrieve_error.

The supplement is below. When APNs close a connection, SSL_read returns 0, and Net::SSLeay:::read returns 0, and Net::SSLeay:::ssl_read_all returns "".

Related: https://github.com/xaicron/p5-Net-APNs-Extended/issues/6

mosasiru commented 9 years ago

I reconsider we should be able to notice that APNs close the connection, so I close this pull-req.