search

xaicron / p5-www-youtube-download

YouTube video download interface.
http://blog.livedoor.jp/xaicron/
Other
38 stars 28 forks source link

Fixed it #26

Closed isync closed 9 years ago

isync commented 10 years ago

The meat of this pull request is that I've fixed the construction of the download url.

Apart from that a new feature: "supply your own user-agent-string"! And some pod/documentation tweaks.

Grab and merge what you like. No need to credit me.

Hi five, isync

oalders commented 9 years ago

@isync what's the use case for customizing the UserAgent?

isync commented 9 years ago

Isn't that obvious? Fooling Google, of course ;)

But seriously, any good downloader has this option: youtube-dl has it, curl has it (-A switch), wget has it (-U switch), so why don't we?

Anyway, please cherry pick: there's still a fix in it for parsing out the YT user, etc.

oalders commented 9 years ago

So, I think setting the user agent string is useful. If you have a moment to address the points I raised and rebase + force-push, that would be helpful.