I added code to get: description, date published, views, thumbnail, familyfriendly, and genre; how do I contribute?

[k-k-k-ken]

Hi,

I have added code to get: description, date published, views, thumbnail, familyfriendly, and genre; how do I contribute?

it's in Download.pm, mostly in prepare_download(), and added routines for each of them, patterned after _fetch_title().

I have not updated any tests, which you might want to do as you incorporate this.

Attached is the updated Download.pm, in case you want to take it from here. Hope this helps!

Download.pm.zip

[oalders]

Hi @k-k-k-ken,

Thanks for this! The best way to get this merged would be to create a pull request which incorporates your changes. Adding some tests as well would be helpful. This module is basically in maintenance mode at this point, so making it as easy as possible for us to merge your changes is the best way of getting them incorporated.

Thanks again for taking the time to provide your code changes to us.

[k-k-k-ken]

Thanks for the quick feedback!

I'm new to GitHub and am unfamiliar with pull requests -- can you point me to some documentation? I tried clicking "New Pull Request" but it just took me to the "Code" tab, with "Compare Changes" -- do I not have enough permissions?

Thanks again!

[oalders]

So, basically this will give you a quick start: https://help.github.com/articles/creating-a-pull-request/

What you need to do is click the "Fork" button above which will fork this repository to your account. Then check out the forked repository and replace Download.pm with your version. You would commit and push that code to Github and then you can create a pull request from the changed code. If you're new to Git as well, you may find it easier to get started with a Desktop app: https://desktop.github.com/

Let me know if you run into any problems.

[k-k-k-ken]

Hi, so I created a pull request with the new code -- please let me know if what I did is correct, or if there are further steps I need to take? Thanks again!