search

xaionaro / edk2-builder-docker

Docker container to build EDK2-based projects. Supports all EDK2 releases out of the box. And has examples of usage.
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

Remove obsolete hacks in build.sh #27

Closed startergo closed 2 years ago

xaionaro commented 2 years ago

@startergo : Hey. I added you to collaborators of this project. If you could accept the invite and push this change to a new branch in this repository, and re-create the Pull Request (from this new branch), I hope the auto-tests will execute. Let me know if this is not convenient for you -- I'll try to find another solution.

Screenshot from 2022-11-24 00-00-14

startergo commented 2 years ago

image This fails on my branch.

xaionaro commented 2 years ago

@startergo : Hey. I added you to collaborators of this project. If you could accept the invite and push this change to a new branch in this repository, and re-create the Pull Request (from this new branch), I hope the auto-tests will execute. Let me know if this is not convenient for you -- I'll try to find another solution.

OK, I did it myself. https://github.com/xaionaro/edk2-builder-docker/pull/28

xaionaro commented 2 years ago

@startergo : Hey. I added you to collaborators of this project. If you could accept the invite and push this change to a new branch in this repository, and re-create the Pull Request (from this new branch), I hope the auto-tests will execute. Let me know if this is not convenient for you -- I'll try to find another solution.

OK, I did it myself. #28

It helped. Merging :)

xaionaro commented 2 years ago

@startergo : Could you review https://github.com/xaionaro/edk2-builder-docker/pull/29 please?