xakep666 / monkey

Library for monkey-patching functions in Go
MIT License
24 stars 0 forks source link

But... Why? #3

Open quenbyako opened 2 years ago

quenbyako commented 2 years ago

Monkey patching is a total evil in programming (except too specific cases, which are still not an argument)... For god sake, why did you publish that?

Also, looks like you didn't read original monkeypatching library license:

Don't use it.

Even author answered, why monkeypatching must not be exist in this world


I also must note you, that publishing projects in opensource is awesome thing, more opensourced projects — better life for developers. But it's better to keep code quality in opensource projects, cause if we won't look on code quality, opensource will become an evil too. Which is unacceptable/

xhd2015 commented 7 months ago

Evil for what? Have you ever used it? Monkey patching is evil if you abuses it.But for testing, I don't see there is any problem with it.

quenbyako commented 7 months ago

@xhd2015 nope, using monkeypatching in tests is more evil than ever, cause if you do something like this in even in tests... Well, you got some problems with architecture for sure.

xhd2015 commented 7 months ago

You don't even have experience about it.