xaksis / vue-good-table

An easy to use powerful data table for vuejs with advanced customizations including sorting, column filtering, pagination, grouping etc
https://xaksis.github.io/vue-good-table/
MIT License
2.16k stars 405 forks source link

Unable to get rid of unnecessary horizontal scrollbar #200

Closed darrylpblack closed 6 years ago

darrylpblack commented 6 years ago

I have used styleClass to customize the table but am unable to get rid of the horizontal scrollbar at the bottom even though it is not needed. Seems to appear in all the samples too. I've tried to explicitly disable it with overflow-x: hidden without any luck. Any ideas? Thanks for your help. Here's the code, modified from your example.

xaksis commented 6 years ago

@darrylpblack what browser are you on? can you create a jsfiddle where I can reproduce this?

darrylpblack commented 6 years ago

Hi Xaksis,

Thanks for getting back to me. I can create a sample for you but even your samples have the unnecessary horizontal scrollbar in them. Here's a quick snapshot with the unnecessary scrollbar show in your vue-good-demos ( https://xaksis.github.io/vue-good-demos/#/simple-table) with a green rectangle around it.

Let me know if you still need a sample.

Thanks,

-Darryl

On Thu, Mar 8, 2018 at 11:40 AM, xaksis notifications@github.com wrote:

@darrylpblack https://github.com/darrylpblack what browser are you on? can you create a jsfiddle where I can reproduce this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xaksis/vue-good-table/issues/200#issuecomment-371544975, or mute the thread https://github.com/notifications/unsubscribe-auth/APXSMQkrwTIT3iEqUvcInBbR81p_tIZ9ks5tcV8JgaJpZM4SelG1 .

xaksis commented 6 years ago

@darrylpblack This should now be fixed in v1.20.3

darrylpblack commented 6 years ago

Xaksis,

Just upgraded; your fix works perfectly. Awesome. Thanks so much.

Your vue-good-table is an extremely valuable and well-built Vue component--great work!

Regards and thanks again,

-Darryl

On Wed, Mar 14, 2018 at 7:54 AM, xaksis notifications@github.com wrote:

Closed #200 https://github.com/xaksis/vue-good-table/issues/200.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xaksis/vue-good-table/issues/200#event-1520748470, or mute the thread https://github.com/notifications/unsubscribe-auth/APXSMR_-vooXWV_VltV1RAvgMJ0FBtDDks5teQUIgaJpZM4SelG1 .

xaksis commented 6 years ago

Thank you so much @darrylpblack! Also, when you get some time, try out version 2.0 (it is currently in Beta). I have added a bunch of overall component improvements there.

darrylpblack commented 6 years ago

Hi,

Did spend a few minutes on Version 2.0. The upgrade guide is great but it would be helpful to have a complementary sample that shows off the new stuff. I got my simple sample working again but it is unclear to me how I get bordering, stripping and condensed table attributes turned on again? Got the nocturnal working but too dark for my use.

I will look again in a few months.

Thanks!

-Darryl

On Wed, Mar 14, 2018 at 9:42 AM, xaksis notifications@github.com wrote:

Thank you so much @darrylpblack https://github.com/darrylpblack! Also, when you get some time, try out version 2.0 (it is currently in Beta). I have added a bunch of overall component improvements there.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xaksis/vue-good-table/issues/200#issuecomment-373024628, or mute the thread https://github.com/notifications/unsubscribe-auth/APXSMZLvQWx8qfZBpkm-dHEEAPW5BimFks5teR5IgaJpZM4SelG1 .

xaksis commented 6 years ago

hey @darrylpblack the new documentation is actually on the new-build branch. You can see it here: https://github.com/xaksis/vue-good-table/tree/new-build

I'll create some recipes (still work in progress for now). Thank you for checking it out.