xalixilax / xali-s-Enhanced-Vanilla-16x

Other
11 stars 4 forks source link

[Feature Request] Respackopts Support #5

Open GeefireMC opened 1 year ago

GeefireMC commented 1 year ago

Respackopts is a mod which allows for resource packs to create their own configuration screens. While OptiFine & OF Alternatives already have configuration screens that allow disabling specific features, those toggles disable those features for all resource packs. Some users would like to keep specific features from other resource packs loaded, while disabling specific features from certain resource packs. Respackopts would allow users to pick and choose what they want on a per-texture basis. On the modrinth page for this pack, it says,

This is the main reason with most of my packs are separated . I want people to be able to choose what they want in their game and how far they are ready to go with it.

So I believe that you would find this mod to be beneficial to your users, as would they. AFAIK it shouldn't affect players without respackopts, either, so the main downside of this would be the added work of you making the configs and supporting them.

xalixilax commented 1 year ago

I know we'll about Respackopts and decided to not work further on it. At the time it had under 1k download and is very hard to develop for. It is capable but not without a lot of brain work. I saw that v2 got release recently so I might give it a lot but I'm not so sure about it. I also started to use auto publish with Github action but and I added a task to clean my pack to be more performing. Sadly it is not letting me use custom folder (I might be wrong but not by default) and I would like to keep it. It lower the pack size by a quarter.

I had it mainly for bushy leaves at first wich was a feature that wasn't alway liked / performing well on lower spec pc.

I'm not saying it won't happen but don't hope for it. At the same time I added the Github action for the ease of publishing so I might do it bit by bit

GeefireMC commented 1 year ago

At the time it had under 1k download and is very hard to develop for. It is capable but not without a lot of brain work. I saw that v2 got release recently so I might give it a lot but I'm not so sure about it.

I've just spent the past hour or two messing around with it for a pack and v2 seems reasonably easy to set up and understand. Even if you don't want to bother setting it all up, I could try my hand at setting it up and making a pull request. I don't know if you'd want that, though.

also started to use auto publish with Github action but and I added a task to clean my pack to be more performing. Sadly it is not letting me use custom folder (I might be wrong but not by default) and I would like to keep it. It lower the pack size by a quarter.

I'm assuming you mean PackSquash? I'm not familiar with Github Actions but your publish.yml file mentions it, so I'm assuming your talking about that. For PackSquash, you can add the lines

['**/{respackopts.json5,*.rpo}']
force_include = true

to your config file and it *should* include all files necessary for respackopts. That's what I'm using anyways, and it works for me.

I'm not saying it won't happen but don't hope for it.

Yeah I get it. I just thought it would be a neat thing to have, but if you can't include it then I understand. Thanks for listening, though :)

xalixilax commented 1 year ago

To be honest I don't mind if you want to create a PR. The artistic side I prefer to keep it to myself but for config I think it's pretty hard to really cause trouble. I like the idea of being more configurable but it was just about how it was done. I had an idea about creating a mod similar to it but I need to find some time since I barely know Java (I know c#) and I'd have to also do my research on fabric and mixing I suppose

Le sam. 10 sept. 2022, 8 h 27 p.m., Geefire @.***> a écrit :

At the time it had under 1k download and is very hard to develop for. It is capable but not without a lot of brain work. I saw that v2 got release recently so I might give it a lot but I'm not so sure about it.

I've just spent the past hour or two messing around with it for a pack and v2 seems reasonably easy to set up and understand. Even if you don't want to bother setting it all up, I could try my hand at setting it up and making a pull request. I don't know if you'd want that, though.

also started to use auto publish with Github action but and I added a task to clean my pack to be more performing. Sadly it is not letting me use custom folder (I might be wrong but not by default) and I would like to keep it. It lower the pack size by a quarter.

I'm assuming you mean PackSquash? I'm not familiar with Github Actions but your publish.yml file mentions it, so I'm assuming your talking about that. For PackSquash, you can add the lines

['*/{respackopts.json5,.rpo}'] force_include = true

to your options.toml and it should include all files necessary for respackopts. That's what I'm using anyways, and it works for me.

I'm not saying it won't happen but don't hope for it.

Yeah I get it. I just thought it would be a neat thing to have, but if you can't include it then I understand. Thanks for listening, though :)

— Reply to this email directly, view it on GitHub https://github.com/xalixilax/xali-s-Enhanced-Vanilla-16x/issues/5#issuecomment-1242826132, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS4ESM633UYIX4PT73LA7DV5URORANCNFSM6AAAAAAQJNRYT4 . You are receiving this because you commented.Message ID: @.***>