search

xamarin / AndroidSupportComponents

Xamarin bindings for Android Support libraries - For AndroidX see https://github.com/xamarin/AndroidX
MIT License
146 stars 56 forks source link

Correct .nuspec file for Xamarin.Android.Support.Design library. #29

Closed Lonelywood closed 7 years ago

Lonelywood commented 7 years ago

Support Libraries Version (eg: 23.3.0):

Version 25.0.1-rc1.

Does this change any of the generated binding API's?

No, this PR doesn't change generated binding API.

Describe your contribution

Correct .nuspec file for Xamarin.Android.Support.Design library.

Add Xamarin.Android.Support.Transition dependency because transition library is required for BottomNavigationView widget.

Without transition library while inflating layout with BottomNavigationView we get java ClassNotFoundException.

java.lang.ClassNotFoundException: android.support.transition.AutoTransition

dnfclas commented 7 years ago

Hi @Lonelywood, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented 7 years ago

@Lonelywood, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Redth commented 7 years ago

Thanks this was manually added to the 25.1.0 branch.