search

xamarin / AndroidSupportComponents

Xamarin bindings for Android Support libraries - For AndroidX see https://github.com/xamarin/AndroidX
MIT License
146 stars 56 forks source link

insert a space between arguments #37

Closed shanhongyue closed 7 years ago

shanhongyue commented 7 years ago

For some unknown reason the argument was added one more times recursively during the build and ended up like

--no-version-vectors--no-version-vectors--no-version-vectors

insert a space between arguments may ignore it

dnfclas commented 7 years ago

Hi @shanhongyue, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Redth commented 7 years ago

Thanks, I've actually fixed this in a slightly different way.

We now invoke a target which will check for the existence of --no-version-vectors and will append the flag if it doesn't already exist in the property. It will also take care of trimming any trailing spaces and explicitly adding a space before appending, so we shouldn't have this issue of sometimes having spaces and sometimes not.

Here's the file if you're interested in having a look: https://github.com/xamarin/AndroidSupportComponents/blob/231d1c8bf8cbb8d356c6033ed6fd47c6a9fe402e/vector-drawable/nuget/merge.targets#L38-L48