search

xamarin / AndroidSupportComponents

Xamarin bindings for Android Support libraries - For AndroidX see https://github.com/xamarin/AndroidX
MIT License
146 stars 56 forks source link

Internal classes are public and may actually be useful. #63

Closed Redth closed 7 years ago

Redth commented 7 years ago

Google for some reason marks classes inside of internal packages as public, and sometimes they are useful.

In this case BottomNavigationItemView and BottomNavigationMenuView are some culprits:

Related to comments on #62 from @corjohnson Some additional info: https://stackoverflow.com/questions/36032177/android-new-bottom-navigation-bar/36033640#36033640 and https://stackoverflow.com/questions/41649494/how-to-remove-icon-animation-for-bottom-navigation-view-in-android/41690461

jamesmontemagno commented 7 years ago

These were available in 25.3.1, but now missing from 25.4.X :(

tuyen-vuduc commented 7 years ago

@Redth I made the fixes for these bugs. Could I make a pull request?

Redth commented 7 years ago

Fixed in 25.4.0.2