search

xamarin / AndroidSupportComponents

Xamarin bindings for Android Support libraries - For AndroidX see https://github.com/xamarin/AndroidX
MIT License
146 stars 56 forks source link

Xamarin.Auth doesnt show back button and doesnt close browser when done #94

Closed josephkandi closed 6 years ago

josephkandi commented 6 years ago

Xamarin.Android Version (eg: 6.0):

Version: 8.2.0.15 (Visual Studio Community)

Operating System & Version (eg: Mac OSX 10.11):

OS 10.13.2

Support Libraries Version (eg: 23.3.0):

25.4.0.2

Describe your Issue:

When using Xamarin.Auth 1.6 with Xamarin Forms when i use presenter.Login(_oAuth2Authenticator); to show the browser for Google authentication, i do not get the back button on the launched browser and when the authentication is successfully done, the browser does not close. This works fine on iOS.

When i downgrade the version to Xamarin.Auth 1.5.0.2 i get the desired behaviour. The back button shows up and when the authentication is complete am returned back to the app.

Steps to Reproduce (with link to sample solution if possible):

Using the sample Xamarin.Auth just upgrade the Xamarin.Auth nuget package to 1.6.0

Include any relevant Exception Stack traces, build logs, adb logs:

newky2k commented 6 years ago

@josephkandi I believe there has been an update to Xamarin.Auth since you logged this issue. Could you please check and see if this has resolved your issue. If not can you tell me which sample you are referring to, or provide a working demo, so I can try and replicate the issue.

Thanks

josephkandi commented 6 years ago

Still same problem exists, i have updated 1.6.0.2. I will try strip away the keys and post a link to a github repo that reproduces the problem.

newky2k commented 6 years ago

@josephkandi Thank you

newky2k commented 6 years ago

@josephkandi I have moved this in to the Xamarin.Auth repo as this make more sense -> https://github.com/xamarin/Xamarin.Auth/issues/315