In #829, I got a little ahead of myself with my quote:
As expected for an open source, cross-platform project, there does not appear to be any issues found that need to be mitigated.
It turns out there were some issues being marked, but the scan doesn't fail the build so they were missed.
Fix 2 things:
Use @pjcollins's more complete solution to store the ApiScan logs and fail the build if any issues were found.
Fix the following failures by removing some framework assemblies that ship with dotnet and we are not redistributing with our packages.
system.objectmodel.dll(,): Error documentationnotfound: Documentation Not Found: presentationframework!System.Windows.Input.CommandValueSerializer is either an undocumented HVP API or the documentation is not discoverable.
mscorlib.dll(,): Error documentationnotfound: Documentation Not Found: system.runtime.compilerservices.visualc!System.Runtime.CompilerServices.SuppressMergeCheckAttribute is either an undocumented HVP API or the documentation is not discoverable.
netstandard.dll(,): Error documentationnotfound: Documentation Not Found: system.componentmodel.typeconverter!System.ComponentModel.Design.DesignerOptionService.DesignerOptionConverter is either an undocumented HVP API or the documentation is not discoverable.
Context: https://github.com/xamarin/AndroidX/pull/829 Context: https://github.com/xamarin/xamarin-android/pull/8605
In #829, I got a little ahead of myself with my quote:
It turns out there were some issues being marked, but the scan doesn't fail the build so they were missed.
Fix 2 things:
dotnetand we are not redistributing with our packages.CI Build: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8875161