search

xamarin / Essentials

Xamarin.Essentials is no longer supported. Migrate your apps to .NET MAUI, which includes Maui.Essentials.
https://aka.ms/xamarin-upgrade
Other
1.53k stars 505 forks source link

added push permissions for Android & iOS #2063

Closed thisisthekap closed 1 year ago

thisisthekap commented 1 year ago

Description of Change

Added push notification permissions for Android and iOS to the Permissons component.

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Added:

Changed:

None

Behavioral Changes

None

PR Checklist

thisisthekap commented 1 year ago

@microsoft-github-policy-service agree [company="fun.music IT GmbH"]

thisisthekap commented 1 year ago

@microsoft-github-policy-service agree company="fun.music IT GmbH"

trampster commented 1 year ago

We also need this change

jfversluis commented 1 year ago

Can we also add something maybe for this in the sample app?

thisisthekap commented 1 year ago

Good idea. Will do.

jamesmontemagno commented 1 year ago

I am not sure how many large changes we want to introduce into Xamarin.Essentials where new work should be done directly in .NET MAUI. I only recommend small bug fixes and maintenance IMHO.

This functionality could be achieved today via https://learn.microsoft.com/en-us/xamarin/essentials/permissions?context=xamarin%2Fandroid&tabs=android#extending-permissions

jfversluis commented 1 year ago

As discussed here and on Discord we're not going to add this to Xamarin.Essentials anymore. Changing the target framework and implementing new public APIs is not a desirable thing that we want to do for a product that has a end-of-life date already set.

I think @trampster got the idea of maybe creating an additional library with the missing permissions since these permissions APIs are pretty extensible. If someone does create that, please add a link here for other people to find it.

Understandably this is not the outcome you have hoped for and I'm sorry about that. This change is very welcome to be added to .NET MAUI so we will have it there.

Thanks for all the time and effort you've spent on this!

thisisthekap commented 1 year ago

@jfversluis As Xamarin.Forms is going to support Android 13 (a prerelease doing so is available at https://github.com/xamarin/Xamarin.Forms/releases/tag/beta-5.0.0-sr15-pre1), I think this PR should be reevaluated.

lassana commented 1 year ago

This has to be reevaluated. Xamarin (and Xamarin.Forms) is claimed to be supported till April 2024, and notification permission is a core part of Android 13 which Xamarin claims to support.

Jerome-Liger commented 1 year ago

Google force to update all our apps to target Android13 before 31/08/2023 on the PlayStore, so please, do not forget Xamarin.Forms apps IN PRODUCTION : August 2023 -> April 2024 : it has to be implemented for me. MAUI (and all the ecosystem) is far away to be ready to migrate all our xamarin.forms production apps...

lndalmd commented 1 year ago

Same here!!!!We are also concerned about Xamarin.Forms ending support until all of our project dependencies have been migrated to MAUI.Leandro AlmeidaEm 22 de ago. de 2023, à(s) 05:02, Jérôme Liger @.***> escreveu: Google force to update all our apps to target Android13 before 31/08/2023 on the PlayStore, so please, do not forget Xamarin.Forms apps IN PRODUCTION : August 2023 -> April 2024 : it has to be implemented for me. MAUI (and all the ecosystem) is far away to be ready to migrate all our xamarin.forms production apps...

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: @.***>