xamarin / Essentials

Xamarin.Essentials is no longer supported. Migrate your apps to .NET MAUI, which includes Maui.Essentials.
https://aka.ms/xamarin-upgrade
Other
1.52k stars 505 forks source link

Make UWP FilePicker FutureAccessList more robust #2093

Closed jfversluis closed 1 year ago

jfversluis commented 1 year ago

Description of Change

When using FilePicker on UWP it will add the entries to something that is called the FutureAccessList. However, that list has a maximum amount of entries and when it reaches that, it will break. This change will add some more robustness.

This adds:

Bugs Fixed

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

jfversluis commented 1 year ago

@DanielGilbert are you still interested in this one? How does this look?

DanielGilbert commented 1 year ago

@DanielGilbert are you still interested in this one? How does this look?

Hi @jfversluis !

It's an improvement to the existing solution, thanks! Although I still stand by my comment, that a library should never interfere with the list. But it is how it is, I guess. :)

jfversluis commented 1 year ago

@DanielGilbert I totally agree. I guess the problem here is that it has been like this since forever and people might have come to rely on this happening now and so it will be a breaking change to remove it entirely. I think the actual impact will be limited, but better safe than sorry.

Thanks for all your input on this!