search

xamarin / Essentials

Xamarin.Essentials is no longer supported. Migrate your apps to .NET MAUI, which includes Maui.Essentials.
https://aka.ms/xamarin-upgrade
Other
1.53k stars 506 forks source link

Change CMAttitudeReferenceFrame to XMagneticNorthZVertical to remove … #2123

Closed robheffo79 closed 5 months ago

robheffo79 commented 5 months ago

…the dependency on the compass calibration, thus removing the dependency on location services.

Description of Change

Changed the CMAttitudeReferenceFrame value from XTrueNorthZVertical to XMagneticNorthZVertical in OrientationSensor.ios.watchos.cs line #19.

This change is trivial and requires no tests, samples or documentation.

Bugs Fixed

- Related to issue #2122

API Changes

None

Behavioral Changes

Orientation Sensor takes calibration from Magnetic North instead of True North. True north requires Location Services to be enabled for the app, introducing a sensitive permission that is not strictly necessary. This change pulls the functionality into line with the behavior of Android, which uses Magnetic North for its calibration.

PR Checklist

jfversluis commented 5 months ago

This would be a breaking change and I don't think we want to do that in this phase of the Xamarin.Essentials lifecycle as we're only months away from sunsetting it.

Thanks for your time and effort here, you might want to consider proposing this still for .NET MAUI as that likely has the same behavior.