search

xamarin / GoogleApisForiOSComponents

MIT License
225 stars 162 forks source link

Add Google User Messaging Platform as separate package. #459

Closed GalaxiaGuy closed 2 years ago

GalaxiaGuy commented 4 years ago

As per issue https://github.com/xamarin/GoogleApisForiOSComponents/issues/455, this separates Google User Messaging Platform into its own package.

I originally wasn't go to do this without getting some confirmation it might be accepted, but to be honest the process looked pretty straightforward.

This moves the UMP bits out of Google.MobileAds and into Google.UserMessagingPlatform. I've left the namespace of Google.MobileAds.Consent the same, and added the UMP package as a dependency.

I bumped the last part of the Google.MobileAds package, but I'm not really sure what I'm supposed to do about version numbers in general.

GalaxiaGuy commented 4 years ago

I was hoping that having Google.MobileAds depend on Google.UserMessagingPlatform, it would mean someone upgrading wouldn't have to do anything, but now I think about that obviously won't be the case (they would have to take a dependency on Google.UserMessagingPlatform.

This would obviously mean a breaking change for anyone upgrading from v7.66.0 who references Google.MobileAds.Consent.

GalaxiaGuy commented 3 years ago

Presumably superseded by: https://github.com/xamarin/GoogleApisForiOSComponents/pull/485

GalaxiaGuy commented 2 years ago

Since #501 has been merged, this PR should no longer be needed.