search

xamarin / GoogleApisForiOSComponents

MIT License
225 stars 162 forks source link

Please, make samples independant from repository, use nuget #473

Open ivmazurenko opened 3 years ago

ivmazurenko commented 3 years ago

As I can see, all references in samples csproj's are used hardcoded paths to this repository, for example:

    <ProjectReference Include="..\..\..\..\source\Firebase\CloudMessaging\CloudMessaging.csproj">
      <Project>{76D97DB8-CAFE-4F0C-9F90-970CB26080FA}</Project>
      <Name>CloudMessaging</Name>
    </ProjectReference>
    <ProjectReference Include="..\..\..\..\source\Firebase\Core\Core.csproj">
      <Project>{9335A59B-3B54-4ED5-8201-B68CFD05CAFB}</Project>
      <Name>Core</Name>
    </ProjectReference>
    <ProjectReference Include="..\..\..\..\source\Firebase\InstanceID\InstanceID.csproj">
      <Project>{754D8F56-C3DB-4E33-91D5-45445AB286EF}</Project>
      <Name>InstanceID</Name>
    </ProjectReference>
    <ProjectReference Include="..\..\..\..\source\Firebase\Installations\Installations.csproj">
      <Project>{65ACD945-5A8A-419D-B9FB-8DFD03C532F4}</Project>
      <Name>Installations</Name>
    </ProjectReference>

In real scenario, all dependencies will be referenced from the NUGET, for example i tried to include references next way:

    <PackageReference Include="Xamarin.Firebase.iOS.CloudMessaging" Version="4.7.1" />
    <PackageReference Include="Xamarin.Firebase.iOS.Core" Version="6.10.4" />
    <PackageReference Include="Xamarin.Firebase.iOS.Crashlytics" Version="4.6.2" />
    <PackageReference Include="Xamarin.Firebase.iOS.Installations" Version="1.7.0" />
    <PackageReference Include="Xamarin.Firebase.iOS.InstanceID" Version="4.8.0" />

And it is not documented, what packages exactly i need to use. App does not starts, fails on runtime, fails with linking, there is tons of scenarios, when firebase does not works properly on my app: "Шаг влево, шаг вправо - расстрел".

I cant reproduce your samples on my local environment without cloning of your repository and putting it into my project, and samples from this repo are synthetic.

Please, update samples to use real nuget, make them independant from referencing projects from filesystem