xamarin / GoogleApisForiOSComponents

MIT License
225 stars 161 forks source link

[Update] Firebase for iOS v8.0.0 #485

Closed dmariogatto closed 3 years ago

dmariogatto commented 3 years ago

Includes

Firebase

Google

Notes

Removed the Wrap methods/properties that where marked as Obsolete (seems like a major version bump is the time to do it šŸ˜…).

Added a new build property that can be used to link Firebase with Ad Id support.

<PropertyGroup>
  <FirebaseWithoutAdIdSupport>True</FirebaseWithoutAdIdSupport>
</PropertyGroup>

There were quite a few binding changes, so would definitely appreciate someone to look them over. All the samples do run & link as far as I can tell.

UMP has been separated out from AdMob (Google.UserMessagingPlatform).

Any issues let me know!

mayhammf commented 3 years ago

@dmariogatto thank you so much for working on this. I just wanna mention that we've used your branch 711 to produce locally built firebase package (with v7.11) and were able to release a build (with FirebaseWithoutAdIdSupport=true) and Apple has approved all of our apps without any issues concerning the tracking transparency stuff.

mayhammf commented 3 years ago

We did have to cleanup some of the project refs in the .sln file to get it to build in Visual Studio. This PR here includes the projects in question https://github.com/dmariogatto/GoogleApisForiOSComponents/pull/1/commits/3c828b797bea1af0321a1ceb0644d31443c6d401

dmariogatto commented 3 years ago

@mayhammf Glad it's helped!

I didn't notice that PR, I'll review and merge it into this branch.

dmariogatto commented 3 years ago

@mayhammf InstanceID was removed as a dependency from Messaging in 8.0.0. You can see the difference in the "dependencies" section of the podspec files - 7.11.0 & 8.0.0.

mayhammf commented 3 years ago

@mayhammf InstanceID was removed as a dependency from Messaging in 8.0.0. You can see the difference in the "dependencies" section of the podspec files - 7.11.0 & 8.0.0.

Thank you @dmariogatto for taking the time to reply. I noticed that i was looking at the wrong branch after i posted my question. That's why i ended up deleting it. But it was too later already šŸ˜‡

dtaylorus commented 3 years ago

@dmariogatto This repo appears to be abandoned. Any chance you would publish the nugets from your branch?

dmariogatto commented 3 years ago

@dtaylorus I'd rather leave that as a last resort, it would fragment Firebase packages/documentation/samples. I don't really want to be the sole maintainer either, I can't commit that I'll always have the time/knowledge to keep this repo up-to-date.

I'll continue updating the bindings while I can & creating PRs. Hopefully at some point they will get reviewed, or there will be some indication if this repo is truly abandoned (or possibly just side-lined while teams are busy with MAUI & .NET 6).

dtaylorus commented 3 years ago

@dmariogatto Fair enough. In the meantime your branch is super helpful. Thanks! I submitted a pull request to your branch for some fixes required to use rewarded and adaptive banner ads.

dmariogatto commented 3 years ago

Now obsolete, see #489