search

xamarin / GoogleApisForiOSComponents

MIT License
225 stars 162 forks source link

[Update] Firebase for iOS v8.10.0 & MLKitVision #501

Closed dmariogatto closed 2 years ago

dmariogatto commented 3 years ago

Previous PRs: #495, #494, #489, #485, #479

Includes

Firebase

Google

Google MLKit

Added a new component category MLKit with new bindings for the below,

Notes

Removed the Wrap methods/properties that where marked as Obsolete (seems like a major version bump is the time to do it 😅).

Added a new build property that can be used to link Firebase with/without Ad ID support.

<PropertyGroup>
  <FirebaseWithoutAdIdSupport>True</FirebaseWithoutAdIdSupport>
</PropertyGroup>

There were quite a few binding changes, so would definitely appreciate someone to look them over. All the samples do run & link as far as I can tell.

UMP has been separated out from AdMob (Google.UserMessagingPlatform).

Any issues let me know!

mayhammf commented 3 years ago

@dmariogatto Thank you for keeping these PRs coming. Do you know if there is a reason they are not getting reviewed/approved by the team?

dmariogatto commented 3 years ago

@mayhammf Unfortunately I do not.

My own speculation is these binding libraries are not a priority for Microsoft, and from what I gather the teams that work on Xamarin/MAUI are short-staffed & don't have the time/resources to maintain these projects. Which isn't ideal as I'd regard binding important ecosystem libraries, such as Firebase, as critical to the long-term success of the platform.

For now, I'll continue to update the bindings with new versions & hopefully it will make the team's job a little easier whenever they get time to look at it.

SotoiGhost commented 2 years ago

@dmariogatto Thank you for this amazing effort and amazing work! 🎉🎉🎉

I'm planning to start reviewing this ASAP, do you have any WIP that I should wait to be merge??

dmariogatto commented 2 years ago

@SotoiGhost

Might as well go with the latest 😀, I've just pushed a new branch firebase-891 (including Maps 5.2, Places 5.1, Cast 4.7 & AdMob 8.13). Shall I create a new PR, or merge into this branch?

Additionally, I just recently created bindings & a sample for the below GoogleML libraries.

firebase-891-mlkitvision - this can be merged along with the Firebase update to 8.9.1, or separately later.

SotoiGhost commented 2 years ago

@dmariogatto Feel free to merge it here. Please, let me know when ready. Thank you!

dmariogatto commented 2 years ago

@SotoiGhost Done 🚀

dmariogatto commented 2 years ago

@SotoiGhost

You should also be aware that some of the new archive files are deeply nested and run into max path length errors on Windows when extracted by XBD. I have already made a PR, https://github.com/xamarin/XamarinComponents/pull/1296, addressing the issue.

dmariogatto commented 2 years ago

@SotoiGhost I've bumped Firebase to 8.10.0, as well as, Google Maps/Places to 6.0.0.

Additionally, as per my comment above XBD has been updated to 0.11.0.