xamarin / GoogleApisForiOSComponents

MIT License
225 stars 161 forks source link

add AppEventDelegate to the public delegates and events #510

Open johanliu897 opened 2 years ago

johanliu897 commented 2 years ago

make AppEventDelegate public

pboisso commented 2 years ago

Thanks a lot for putting this together. Xamarin folks, when can we expect this to be added to the public official release?

pboisso commented 2 years ago

@SotoiGhost, would you be the person who can approve this pull request?

pboisso commented 2 years ago

@jfversluis, I'm taking a chance here. Are those iOS bindings supported by Xamarin at all and would you happen to know who is responsible for publishing updates? Thanks a lot in advance!

jfversluis commented 2 years ago

Hey there @pboisso! Thanks for the ping! I think we should not expect of people to respond within a couple of hours, because timezones and especially in the holiday season with lots of people having time off.

Other than that, I know that Israel is wanting to pick up this project again indeed. So things should be happening here, I can't give you any promises on when that will be. We, as a bigger Microsoft initiative, have a Discord server: https://aka.ms/dotnet-discord there you should be able to interact with him and the team a bit easier as well and probably find some more info on project like these and their current status.

Thanks!

GalaxiaGuy commented 2 years ago

It looks this is also resolved in the PR to update all the bindings: https://github.com/xamarin/GoogleApisForiOSComponents/pull/501

johanliu897 commented 2 years ago

@GalaxiaGuy Thank you for your reply. So this change will be included with the next release? Then when would be the next release?

jfversluis commented 2 years ago

Hey everyone! I'm not entirely up to date with this side of the Xamarin ecosystem, I do know there is some movement around the binding projects. I don't have a timeline for you at this time, but hopefully there will be some updates for you soon.

Thanks for your patience!

pboisso commented 2 years ago

Hello @GalaxiaGuy , I've looked at PR #501, but don't see anything about GoogleMobileAds. Is it possible that it is not part of #501 and that we still need this PR? Thanks @jfversluis for following up, very appreciated.

GalaxiaGuy commented 2 years ago

So...

There are changes to MobileAds in the PR (this URL should show the diff but it takes a while to load: https://github.com/xamarin/GoogleApisForiOSComponents/pull/501/files#diff-da96e4667193cd49bfe088cd906139130925eedcdb5ae7ccd260c15a07e7c009 )

But... I don't think they include the ones you want, so it looks like they would still be needed.

dmariogatto commented 2 years ago

@GalaxiaGuy @pboisso @johanliu897

These changes aren't in #501. I usually do diffs on the framework header files to find the changes and update the bindings. Looks like this event delegate was missed.

johanliu897 commented 2 years ago

@dmariogatto Thank you for your feedback. Really this MR is needed for our app. Please let me know this could be included for the next release?

dmariogatto commented 2 years ago

@johanliu897 I don't see any reason why this couldn't be included in the next release. It's a reasonably simple change.

Unfortunately, I cannot provide any timeline (I don't have access to any information beyond what's public on this repo).

It's not ideal, but depending on your project time constraints you could build the nuget packages you need locally and use them until this repo is officially updated.

pboisso commented 2 years ago

Hello @dmariogatto, I have tried to build the nuget locally using dotnet cake, but getting lots of errors. See some attached...

Would you know where we could find step by step instructions on how to build those nugets by any luck?. This is a first time here with dotnet cake.

Thanks in advance for your help, very appreciated !

image

dmariogatto commented 2 years ago

@pboisso You'll need to use Cake version 0.38.0, as the build scripts aren't compatible with later version.

dotnet tool install -g cake.tool --version 0.38.5

You also need to build the project on macOS, that screenshot looks like Windows.