search

xamarin / GooglePlayServicesComponents

Other
314 stars 146 forks source link

Adjusted Bindings for com.android.billingclient #747

Closed tipa closed 1 year ago

tipa commented 1 year ago

Does this change any of the generated binding API's?

Yes. It binds getConnectionState as ConnectionState property with BillingClient.ConnectionState enum return value.

Describe your contribution

This PR binds getConnectionState as ConnectionState property with BillingClient.ConnectionState enum return value, as proposed here. In is documented that the getConnectionState method returns one of the four BillingClient.ConnectionStates:https://developer.android.com/reference/com/android/billingclient/api/BillingClient#getConnectionState()

This PR also removes bindings for APIs that have been removed in previous versions of the library, namely setChildDirected / ChildDirected, setUnderAgeOfConsent / UnderAgeOfConsent and related enums, see here: https://developer.android.com/google/play/billing/release-notes#3-0 This change reduces build warnings.

Comments: This PR does not change the bindings under the billing-ktx folder - this might have to be adjusted. From my perspective, I don't see the need to bind the Kotlin library, isn't the Java one "good enough" for .NET developers?

tipa commented 1 year ago

Any problems with this PR?

tipa commented 1 year ago

Are there any problems with this PR?

moljac commented 1 year ago

Are there any problems with this PR?

Seems so. Does not build. Let me rebase/merge and see.

tipa commented 1 year ago

Any hopes this will ever get merged @moljac? :) There have been more changes to the billing client in the meantime (e.g. the NETWORK_ERROR enum is not bound). I can also submit a PR for that, but only if there is a change that it will be considered for merging

moljac commented 1 year ago

Any hopes this will ever get merged @moljac? :)

You created this PR and shortly after (IIRC it was on the same day - but not sure) that I left few comments that are still unanswered/pending. I am sorry, but I really have tight schedule and 24 hrs day too, so I was not able to find answers myself.

Some form of feedback/answer/communication would really be nice.

tipa commented 1 year ago

I cannot recall any questions that were directed to me, otherwise I would have gladly answered them.

moljac commented 1 year ago

I cannot recall any questions that were directed to me, otherwise I would have gladly answered them.

Don't you see review comments? Hmh. I am looking at them right now.

tipa commented 1 year ago

No I don't. Where exactly am I supposed to see them? I have wrote you a message in Discord with screenshots of what I see